Name: person-api
Owner: HM Land Registry
Description: null
Created: 2017-08-01 14:24:53.0
Updated: 2017-08-31 16:07:58.0
Pushed: 2017-10-05 12:44:18.0
Homepage: null
Size: 21
Language: Python
GitHub Committers
| User | Most Recent Commit | # Commits |
|---|
Other Committers
| User | Most Recent Commit | # Commits |
|---|
This repository contains a Python3-based Flask application structured in the way that all Land Registry Flask APIs should be structured going forwards.
|Route|What it does|
|—|—|
|GET /health|Returns some basic information about the app (JSON)|
|GET /health/cascade/
Sample data is required but not provided here.
Data should be placed in property_api/data and should be structured as shown:
a
rson_id1.json
rson_id2.json
.)
This app supports the HM Land Registry universal dev-env, if using this adding the following to your dev-env config file is enough:
rson-api:
repo: git@github.com:LandRegistry/person-api.git
branch: develop
The Docker image it creates (and runs) will install all necessary requirements and set all environment variables for you.
(The third party libraries are defined in requirements.txt and can be installed using pip)
on3 -m flask run
k run
run
The unit tests are contained in the unit_tests folder. Pytest is used for unit testing. To run the tests use the following command:
unittest
just py.test)
To run them and output a coverage report and a junit xml file run:
report="true" unittest
These files get added to a test-output folder. The test-output folder is created if doesn't exist.
You can run these commands in the app's running container via docker-compose exec person-api <command> or exec person-api <command>. There is also an alias: unit-test person-api and unit-test person-api -r will run tests and generate reports respectively.
The integration tests are contained in the integration_tests folder. Pytest is used for integration testing. To run the tests and output a junit xml use the following command:
integrationtest
py.test integration_tests)
This file gets added to the test-output folder. The test-output folder is created if doesn't exist.
To run the integration tests if you are using the common dev-env you can run docker-compose exec person-api make integrationtest or, using the alias, integration-test person-api.
Provided via configuration.yml, Dockerfile and fragments/docker-compose-fragment.yml.
configuration.yml lists the commodities the dev env needs to spin up e.g. postgres. The ELK stack is spun up when “logging” is present.
The docker-compose-fragment.yml contains the service definiton, including the external port to map to, sharing the app source folder so the files don't need to be baked into the image, and redirection of the stdout logs to logstash via syslog.
The Dockerfile simply sets the APP_NAME environment variable and installs the third party library requirements. Any further app-specific variables or commands can be added here.
Flask-LogConfig is used as the logging implementation. It is registered in a custom extension called enhanced_logging. There is also a filter that adds the current trace id into each log record from g, and a formatter that puts the log message into a standard JSON format. The message can then be correctly interpreted by both the dev-env and webops ELK stacks. The configuration that tells Python logging to use those formatters and the filter is also set up in enhanced_logging.
main.py imports from app.py in order to trigger the setup of the app and it's extensions. It also provides the app object to manage.py.
manage.py contains the app object which is what should be given to a WSGI container such as gunicorn. It is also where Alembic database migration code is to be placed.
All Flask extensions (enhanced logging, SQLAlchemy, socketIO etc) shoud be registered in extensions.py. First they are created empty, then introduced to the app in the register_extensions() method (which is then called by main.py during initialisation).
Makefile - This provides generic language-independent functions to run unit and integration tests (useful for the build pipeline).
Provided via unit_test and integration_test directories. These locations do not have an __init__.py so the tests cannot be accidentally imported into other areas of the app. This links in with the management script as it expects the tests to be in these locations. The file setup.cfg also contains the default test entry point and coverage settings.
Provided by the after_request() method in app.py. The exact version of the API interface spec is returned, in case clients need to know (the URL will only contain the major version as per the API manual).
Provided by the before_request() method in main.py in the enhanced_logging custom extension. If a header of that name is passed in, it extracts it and places it into g for logging (see next section) and also creates a requests Session object with it preset as a header. This allows the same value to propagate throughout the lifetime of a request regardless of how many UIs/APIs it passes through - making debugging and tracing of log messages much easier.
Note that for the propagation to work, g.requests must be used for making calls to other APIs rather than just requests.
In exceptions.py there is a custom exception class ApplicationError defined, which can be raised by applications that need to send back details of an error to the client. There is a handler method defined that converts it into a consistent response, with JSON fields and the requested http status code.
There is also a handler method for any other types of exception that manage to escape the route methods. These are always http code 500.
Both handlers are registered in the register_exception_handlers() method, which is called by main.py in a similar way to registering blueprints.
All config variables the app uses are created in config.py. It is a plain python module (not a dict or object) and no region-specific code. The mandatory variables are FLASK_LOG_LEVEL (read by Flask automatically), COMMIT and APP_NAME (both used in the health route).
This should be the only place environment variables are read from the underlying OS. It is effectively the gateway into the app for them.
Routes are logically segregated into separate files within /views. By default a general.py is provided that creates the health routes (see table above) that returns a standardised set of JSON fields. Note how the app name is retrieved using the APP_NAME config variable (which in turn comes from the environment).
Blueprints are registered in the register_blueprints method in blueprints.py (which is then called by main.py during initialisation).